Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use RelFileNodeId instead of Oid for relfilenode. #161

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

HuSen8891
Copy link
Collaborator

Currently, relfilenode is extended from 32 bit(Oid) to 64 bit(RelFileNodeId). But Oid is still used for relfilenode in some cases, fix those cases through replacing Oid with RelFileNodeId.

Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

Currently, relfilenode is extended from 32 bit(Oid) to 64 bit(RelFileNodeId).
But Oid is still used for relfilenode in some cases, fix those cases through
replacing Oid with RelFileNodeId.
@my-ship-it my-ship-it merged commit a0fb140 into cloudberrydb:main Aug 21, 2023
6 checks passed
my-ship-it pushed a commit that referenced this pull request Aug 31, 2023
Currently, relfilenode is extended from 32 bit(Oid) to 64 bit(RelFileNodeId).
But Oid is still used for relfilenode in some cases, fix those cases through
replacing Oid with RelFileNodeId.
@HuSen8891 HuSen8891 deleted the RelfileNodeID_Fix branch September 27, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants