-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: update the building guide for Linux #170
Conversation
PR has been generated, please help me have a look at what's the problem, thank you@tuhaihe @tuhaihe |
Hi @Zhangbaowen-Hashdata: Thanks for your contribution. Please squash your commits down to one before this PR is merged. Maybe you can take our coding guide as a reference. |
cf6c82d
to
2dbc18d
Compare
2dbc18d
to
d19c668
Compare
d19c668
to
e4288b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tuhaihe LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since the previous document is a legacy document, much of the code may be invalid, so we verified and tidied it up. The accuracy of the document is ensured, which is easy for users to read, and the environment can be quickly built according to the document.
e4288b8
to
1b3b3e4
Compare
Hi @baotingfang @my-ship-it, please help review this PR, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Since the previous document is a legacy document, much of the code may be invalid, so we verified and tidied it up. The accuracy of the document is ensured, which is easy for users to read, and the environment can be quickly built according to the document.
closes: #ISSUE_Number
Change logs
Since the previous document is a legacy document, much of the code may be invalid, so we verified and tidied it up. The accuracy of the document is ensured, which is easy for users to read, and the environment can be quickly built according to the document.
Why are the changes needed?
Ensure that the documentation is accurate and usable
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
According to the documents needed by the users can quickly build on Linux environment
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel