Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: update editor settings for CloudberryDB #171

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Aug 31, 2023


Change logs

Update src/tools/editors files and .editorconfig for Cloudberry Database, including unifying the the line's max length as 78 characters. You can copy these files to the your editors configuration files to apply them.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

avamingli
avamingli previously approved these changes Aug 31, 2023
Update `src/tools/editors` files and `.editorconfig` for Cloudberry
Database, including unifying the the line's max length as 78 characters.
You can copy these files to the your editors configuration files to
apply them.
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 4ab732b into cloudberrydb:main Sep 6, 2023
6 checks passed
@tuhaihe tuhaihe deleted the editor branch September 26, 2023 02:41
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
Update `src/tools/editors` files and `.editorconfig` for Cloudberry
Database, including unifying the the line's max length as 78 characters.
You can copy these files to the your editors configuration files to
apply them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants