Add hooks for plugins to get control in transientrel_init/intorel_initplan. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
reviewed
Sep 18, 2023
| @@ -611,11 +592,6 @@ intorel_initplan(struct QueryDesc *queryDesc, int eflags) | |||
| int attnum; | |||
| TupleDesc typeinfo = queryDesc->tupDesc; | |||
|
|
|||
| /* If EXPLAIN/QE, skip creating the "into" relation. */ | |||
| if ((eflags & EXEC_FLAG_EXPLAIN_ONLY) || | |||
There was a problem hiding this comment.
Why we move these checks out?
There was a problem hiding this comment.
make sanity check first, we can skip stepping into the function for some cases.
my-ship-it
reviewed
Sep 18, 2023
my-ship-it
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel