Doc: update the building guide for MacOS #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The README.macos.md document has been uploaded successfully, please check it out and give some suggestions.Thank you! |
tuhaihe
requested review from
tuhaihe,
baotingfang,
Ray-Eldath,
TomShawn and
my-ship-it
tuhaihe
requested changes
Sep 25, 2023
Zhangbaowen-Hashdata
force-pushed
the
main
branch
2 times, most recently
from
ada499f
to
84d2d6a
Compare
TomShawn
reviewed
Sep 26, 2023
Ray-Eldath
suggested changes
Sep 26, 2023
TomShawn
reviewed
Sep 26, 2023
tuhaihe
reviewed
Sep 26, 2023
Zhangbaowen-Hashdata
force-pushed
the
main
branch
3 times, most recently
from
37f980c
to
e00ed85
Compare
Ray-Eldath
approved these changes
Sep 26, 2023
Ray-Eldath
suggested changes
Sep 26, 2023
Zhangbaowen-Hashdata
force-pushed
the
main
branch
from
e00ed85
to
4b50de8
Compare
tuhaihe
previously approved these changes
Sep 27, 2023
baotingfang
previously approved these changes
Sep 27, 2023
Ray-Eldath
suggested changes
Sep 27, 2023
Zhangbaowen-Hashdata
dismissed stale reviews from baotingfang and tuhaihe
via
3668cc6
Zhangbaowen-Hashdata
force-pushed
the
main
branch
from
4b50de8
to
3668cc6
Compare
Our team has thoroughly reviewed and significantly improved the documentation for the macOS system. We have left no stone unturned in our efforts to ensure that our instructions for setting up the Mac development environment, compiling and installing cbdb, and verifying the cluster are crystal clear. We have conducted extensive testing on version 13.4+ on various chips, including intel, M1, and M2, and have confirmed that all of them are capable of flawlessly executing the aforementioned functions.
Zhangbaowen-Hashdata
force-pushed
the
main
branch
from
3668cc6
to
80b2191
Compare
Ray-Eldath
approved these changes
Sep 27, 2023
tuhaihe
approved these changes
Sep 28, 2023
my-ship-it
approved these changes
Sep 28, 2023
baotingfang
pushed a commit
that referenced
this pull request
Dec 1, 2023
Our team has thoroughly reviewed and significantly improved the documentation for the macOS system. We have left no stone unturned in our efforts to ensure that our instructions for setting up the Mac development environment, compiling and installing cbdb, and verifying the cluster are crystal clear. We have conducted extensive testing on version 13.4+ on various chips, including intel, M1, and M2, and have confirmed that all of them are capable of flawlessly executing the aforementioned functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #ISSUE_Number
Change logs
We changed the related documents of cbdb deployment on macos, updated the content of the documents, modified the documents from the aspects of environmental deployment, compilation and installation, and optimized the macos documents with the assistance of document students.
Why are the changes needed?
Ensure that the documentation is accurate and usable
Does this PR introduce any user-facing change?
According to the documents needed by the users can quickly build on MacOS environment
How was this patch tested?
By manually executing the instructions in the readme, it can quickly build cbdb and verify whether it is available
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel