Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Add git hooks for Cloudberry Database development #221

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Sep 26, 2023

Don't merge this PR, until it is ready!


Change logs

For better development quality, we customize the Git hooks to remind developers to check their work. We use pre-commit, prepare-commit-msg, commit-msg, and pre-push hooks to trigger automatic checks when running git commit and git push.

Why are the changes needed?

For better development quality

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Install the hooks in the new dir.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready🥳

For better development quality, we customize the Git hooks to remind
developers to check their work. We use pre-commit, prepare-commit-msg,
commit-msg, and pre-push hooks to trigger automatic checks when running
`git commit` and `git push`.
@Ray-Eldath
Copy link
Contributor

Ray-Eldath commented Nov 3, 2023

wut'bout using https://github.com/jorisroovers/gitlint? I think introducing a python dependencies is far better than wiring unportable shell scripts that differs from shell to shell. besides, our gpinitsystem etc. utilities already relied on Python 3 environment so this should not introduce any external dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants