Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: support hashdata tableam in Orca #222

Conversation

gongxun0928
Copy link
Contributor

closes: #ISSUE_Number


Change logs

RetrieveRelStorageType add a magic number 7015. we use the am_id(7015) we
assigned to the custom table am, and let the orca optimizer treat this
columnar storage format as AOCS to generate an execution plan

At present, there is no way to extend orca to support custom table am. So here we use the am_id(7015) we assigned to the custom table am, and let the orca optimizer treat this columnar storage format as AOCS to generate an execution plan
Why use the magic number 7015 instead of the macro definition? Just to make it look like it doesn't make sense, so others will notice that the logic needs to be refactored

Why are the changes needed?

we defined a custom table am using columnar storage, but the orca optimizer does not support am other than HEAP/AO/AOCS.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

1. RetrieveRelStorageType add a magic number 7015. we use the am_id(7015) we
assigned to the custom table am, and let the orca optimizer treat this
columnar storage format as AOCS to generate an execution plan
@gongxun0928 gongxun0928 added type: Bug Something isn't working and removed type: Bug Something isn't working labels Sep 26, 2023
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 6fba5ca into cloudberrydb:union_store_catalog Sep 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants