bugfix: support hashdata tableam in Orca #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #ISSUE_Number
Change logs
RetrieveRelStorageType add a magic number 7015. we use the am_id(7015) we
assigned to the custom table am, and let the orca optimizer treat this
columnar storage format as AOCS to generate an execution plan
At present, there is no way to extend orca to support custom table am. So here we use the am_id(7015) we assigned to the custom table am, and let the orca optimizer treat this columnar storage format as AOCS to generate an execution plan
Why use the magic number 7015 instead of the macro definition? Just to make it look like it doesn't make sense, so others will notice that the logic needs to be refactored
Why are the changes needed?
we defined a custom table am using columnar storage, but the orca optimizer does not support am other than HEAP/AO/AOCS.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel