Doc: merge docs for CBDB compilation on Linux systems #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hiiii, @TomShawn welcome!馃帄 Thanks for taking the effort to make our project better! 馃檶 Keep making such awesome contributions!
|
@tuhaihe @Zhangbaowen-Hashdata PTAL, thanks! |
tuhaihe
requested changes
Sep 27, 2023
There was a problem hiding this comment.
Great work!
-
Could you update your commit title by following our commit conventions?
-
Do we need to update the
readmes/README.mdfile?
Ray-Eldath
reviewed
Sep 27, 2023
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
2 times, most recently
from
e7ecb91
to
1a2c244
Compare
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
from
821850a
to
9f5cc3e
Compare
tuhaihe
changed the title
tuhaihe
requested review from
Zhangbaowen-Hashdata,
tuhaihe,
baotingfang and
my-ship-it
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
from
9f5cc3e
to
02fb73a
Compare
tuhaihe
reviewed
Oct 26, 2023
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
2 times, most recently
from
141dba7
to
8df0831
Compare
Ray-Eldath
suggested changes
Oct 26, 2023
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
from
8df0831
to
0e2d4d7
Compare
Ray-Eldath
approved these changes
Oct 27, 2023
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
from
b96da17
to
0e2d4d7
Compare
The docs for compiling CBDB on Linux systems are distributed in 2 files: readmes/README.Linux.md and readmes/README.md. This is not user-friendly enough. This PR merges the content into one document for a better reading experience.
TomShawn
force-pushed
the
merge-linux-compile-docs
branch
from
0e2d4d7
to
6514891
Compare
tuhaihe
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for compiling CBDB on Linux systems are distributed in 2 files:
readmes/README.Linux.mdandreadmes/README.md. This is not user-friendly enough. This PR merges the content into one document for a better reading experience.Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel