Open proper AO/AOCS segment files according to data volume #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inserting into AO/AOCS tables, we will open segment files equal to GUC gp_appendonly_insert_files anyway before. It will create uncessary empty segment files and increase total number of that, which leads to unexpected regression diffs related to total segfile number of AO/AOCS tables. Open new segment file if there are enough data on the fly. As we fix it, workarounds of gp_appendonly_insert_files in regression tests scripts could be resolved. Adjust gp_appendonly_insert_files for some cases that have more data than gp_appendonly_insert_files_tuples_range to pass test like: inject fault and etc. Authored-by: Zhang Mingli avamingli@gmail.com
avamingli
force-pushed
the
ao_open_files_accord_rows
branch
from
e5128e0
to
b26abd6
Compare
avamingli
commented
Oct 19, 2023
avamingli
changed the title
lss602726449
approved these changes
Oct 19, 2023
Ray-Eldath
approved these changes
Oct 25, 2023
yjhjstz
reviewed
Oct 30, 2023
yjhjstz
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting into AO/AOCS tables, we will open segment files equal to GUC gp_appendonly_insert_files anyway before. It will create uncessary empty segment files and increase total number of that, which leads to unexpected regression diffs related to total segfile number of AO/AOCS tables.
Open new segment file if there are enough data on the fly.
As we fix it, workarounds of gp_appendonly_insert_files in regression tests scripts could be resolved.
Adjust gp_appendonly_insert_files for some cases that have more data than gp_appendonly_insert_files_tuples_range to pass test like: inject fault and etc.
Authored-by: Zhang Mingli avamingli@gmail.com
closes: #215
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallel