Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cases related to external_fts #254

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

avamingli
Copy link
Collaborator

Plan Seq scan on gp_segment_configuration would be replaced by Function Scan on gp_get_segment_configuration when external_fts is on.

Inconsistence between CIs will cause such cases to fail. Ignore these as workaround.

Authored-by: Zhang Mingli avamingli@gmail.com

closes: #246


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

Plan Seq scan on gp_segment_configuration would be replaced
by Function Scan on gp_get_segment_configuration when
external_fts is on.

Inconsistence between CIs will cause such cases to fail.
Ignore these as workaround.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli self-assigned this Oct 20, 2023
@Ray-Eldath
Copy link
Contributor

Ray-Eldath commented Oct 23, 2023

I think regress has a feature of automatically matches multiple expected file and choose the one generating the shortest diff, we can have two rpt_joins.out named rpt_joins_1.out and rpt_joins_2.out, one for external_fts=on one for =off. regress could choose between them automatically (this is how we fix xml.out in #206). now that we already fixed log and results uploading in #240 we can directly download CI output and put it as rpt_joins_2.out and everything should works fine again.

@avamingli
Copy link
Collaborator Author

I think regress has a feature of automatically matches multiple expected file and choose the one generating the shortest diff, we can have two rpt_joins.out named rpt_joins_1.out and rpt_joins_2.out, one for external_fts=on one for =off.

You are right, and we have a xxx_external_fts.out technique to handle that.
We have a internal discussion, the conclusion are:
xxx_external_fts.out could resolve this, but we only have 2 lines diff and have to copy 2000 lines for a new file.
The root cause is inconsistent GUCs between Github and Release CI, a external_fts CI will be added for Github later.
This is a workaround, we will take such cases back after that CI enabled.

Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it
Copy link
Contributor

#246

@avamingli avamingli merged commit 371fc97 into cloudberrydb:main Oct 27, 2023
6 checks passed
@avamingli avamingli deleted the workaround_for_external_fts branch October 27, 2023 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] rpt_joins case failed
4 participants