Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: github action support run external_fts test case #256

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

smartyhero
Copy link
Contributor

@smartyhero smartyhero commented Oct 23, 2023


Change logs

Github action support run external_fts test case

After submitting the PR,the external_fts mode will be used for testing.
The code must be merged after passing the test.

Why are the changes needed?

Keep the main branch code correct

Does this PR introduce any user-facing change?

The CBDB external_fts pipeline must also be passed before the code
can be merged

How was this patch tested?

After creating PR, the CBDB external_fts pipeline will be triggered.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiiii, @smartyhero welcome!馃帄 Thanks for taking the effort to make our project better! 馃檶 Keep making such awesome contributions!

@Ray-Eldath
Copy link
Contributor

Ray-Eldath commented Oct 23, 2023

what about add the same concurrency section as in #233?

@my-ship-it
Copy link
Contributor

Could you please provide more details information? Thanks

@tuhaihe
Copy link
Member

tuhaihe commented Oct 26, 2023

Hi @smartyhero, thanks for your contribution. You can take our contribute workflow for reference for the commit message conventions. Also, please squash your commits down to 1 to make the commit history more clear.

@smartyhero smartyhero changed the title Actions debug Enhancement: github action support run external_fts external_fts test case Oct 30, 2023
@smartyhero smartyhero changed the title Enhancement: github action support run external_fts external_fts test case Enhancement: github action support run external_fts test case Oct 30, 2023
baotingfang
baotingfang previously approved these changes Oct 31, 2023
Copy link
Contributor

@baotingfang baotingfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

After submitting the PR,the external_fts mode will be used for testing.
The code must be merged after passing the test.
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 1dfe98e into cloudberrydb:main Nov 1, 2023
10 checks passed
@smartyhero smartyhero deleted the actions_debug branch November 1, 2023 03:39
@Ray-Eldath
Copy link
Contributor

Ray-Eldath commented Jan 2, 2024

is external_fts really enabled on CI? pg_regress says that they're disabled even in the external_fts pipeline:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants