Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix hashjoin_spill avg result diff in parallel mode #260

Merged

Conversation

avamingli
Copy link
Collaborator

It's hard to reproduce stably, the possible reason may be related to avg() within parallel workers.

Commit 11c8669
adds parallel query support functions for assorted aggregates.

Add a cast ::numeric to workaround avg(int),
like commit 77a3be3

Authored-by: Zhang Mingli avamingli@gmail.com

This may resolve #259 , but I'm not sure, we should keep that issue open for a certain months to see the result.

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

It's hard to reproduce stably, the possible reason may be
related to avg() within parallel workers.

Commit 11c8669
adds parallel query support functions for assorted aggregates.

Add a cast ::numeric to workaround avg(int),
like commit 77a3be3

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli self-assigned this Oct 24, 2023
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfphoenix78
Copy link
Collaborator

+1

Copy link
Collaborator

@gfphoenix78 gfphoenix78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avamingli avamingli merged commit 051f104 into cloudberrydb:main Oct 26, 2023
6 checks passed
@avamingli avamingli deleted the try_fix_hashjoin_spill_results_diff branch October 26, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] flaky incorrect results of hashjoin_spill in parallel mode on x86_64
3 participants