Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit CI concurrency to one per PR, redux #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Ray-Eldath
Copy link
Contributor

@Ray-Eldath Ray-Eldath commented Oct 24, 2023

This PR should only be merged after CI pipeline considered stable again.
This PR reverts #258.


In current workflow, when newer commit comes, old pipeline won't get canceled, which wastes resources and cause unnecessary CI failure emails. This PR limits concurrency to one per PR. when newer commit comes, stale CI jobs will be automatically cancelled.

See: https://stackoverflow.com/a/72408109/8711684

@Ray-Eldath Ray-Eldath force-pushed the revert-258-revert-233-ci-concurrency branch from e3e1625 to 0881a53 Compare October 24, 2023 08:09
@Ray-Eldath Ray-Eldath changed the title Limit CI concurrency to one per PR Limit CI concurrency to one per PR, redux Oct 24, 2023
@Ray-Eldath Ray-Eldath marked this pull request as ready for review October 26, 2023 01:51
@my-ship-it my-ship-it self-requested a review November 3, 2023 09:13
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ray-Eldath Ray-Eldath force-pushed the revert-258-revert-233-ci-concurrency branch from 0881a53 to a3884f3 Compare November 3, 2023 09:52
This reverts commit 6fa22ec.
Revert "Revert "Limit CI concurrency to one per PR""

In current workflow, when newer commit comes, old pipeline won't get
canceled, which wastes resources and cause unnecessary CI failure
emails. This PR limits concurrency to one per PR. when newer
commit comes, stale CI jobs will be automatically cancelled.

See: https://stackoverflow.com/a/72408109/8711684
See: cloudberrydb#258
@my-ship-it my-ship-it force-pushed the revert-258-revert-233-ci-concurrency branch from a3884f3 to 5190f9d Compare November 9, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants