Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct shared hash table rows estimation #263

Merged

Conversation

avamingli
Copy link
Collaborator

This is added by me, it's a thinko, at least not correct now.
ReplicatedWorkers path only has the data parallel workers should have.

The subpath's rows is set correctly no matter what locus it is.
Keep it with UPSTREAM.
For shared hash table size estimation, we need the total number, so we need to undo the division.

Authored-by: Zhang Mingli avamingli@gmail.com

closes: #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to @cloudberrydb/dev team for review and approval when your PR is ready馃コ

The subpath's rows is set correctly no matter what locus it is.
Keep it with UPSTREAM.
For shared hash table size estimation, we need the total
number, so we need to undo the division.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli self-assigned this Oct 25, 2023
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 568de79 into cloudberrydb:main Nov 3, 2023
6 checks passed
baotingfang pushed a commit that referenced this pull request Dec 1, 2023
The subpath's rows is set correctly no matter what locus it is.
Keep it with UPSTREAM.
For shared hash table size estimation, we need the total
number, so we need to undo the division.

Authored-by: Zhang Mingli avamingli@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants