Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: update pull request template for CBDB #287

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

tuhaihe
Copy link
Member

@tuhaihe tuhaihe commented Nov 6, 2023


Change logs

Update the keyword from 'closes' to 'fix' to help developers to link a pull request to an issue easily. And cancel to mention the cloudberrydb/dev team when one PR is submitted.

Why are the changes needed?

Update the pull_request template.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No test is needed.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready馃コ

Update the keyword from 'closes' to 'fix' to help developers to link a
pull request to an issue easily. And cancel to mention the
cloudberrydb/dev team when one PR is submitted.
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit f7ced46 into cloudberrydb:main Nov 6, 2023
8 checks passed
@Ray-Eldath
Copy link
Contributor

lovin'it!

baotingfang pushed a commit that referenced this pull request Dec 1, 2023
Update the keyword from 'closes' to 'fix' to help developers to link a
pull request to an issue easily. And cancel to mention the
cloudberrydb/dev team when one PR is submitted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants