Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pg_class instead of gp_segment_configuration to test Entry. #294

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

avamingli
Copy link
Collaborator

@avamingli avamingli commented Nov 10, 2023

Commit 371fc97 ignore cases related to external_fts.
As we have external_fts CI now, recover the test case.

To avoid copying large unnecessary cases for just one or several case using gp_segment_configuration, use pg_class to test Entry locus.

When external_fts is on Seq scan on
gp_segment_configuration would be replaced by
Function Scan on gp_get_segment_configuration
Inconsistence between CIs will cause such cases to fail.

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready馃コ

Commit 371fc97 ignore cases related to external_fts.
When external_fts is on Seq scan on
gp_segment_configuration would be replaced by
Function Scan on gp_get_segment_configuration
Inconsistence between CIs will cause such cases to fail.

To avoid copying large unnecessary cases for just one or
several case using gp_segment_configuration, use pg_class
to test Entry locus.

Authored-by: Zhang Mingli avamingli@gmail.com
@avamingli avamingli self-assigned this Nov 10, 2023
@avamingli
Copy link
Collaborator Author

pg_upgrade failed once again #262

Failure, exiting

real	0m0.156s
user	0m0.023s
sys	0m0.041s
ERROR: Failure encountered in upgrading qd node
/code/gpdb_src/src/bin/pg_upgrade /code/gpdb_src/src/bin/pg_upgrade/tmp_check/upgrade/qd /code/gpdb_src/src/bin/pg_upgrade
make[1]: *** [Makefile:78: check] Error 1
make: *** [GNUmakefile:198: installcheck-world-src/bin/pg_upgrade-recurse] Error 2
make: Target 'installcheck-world' not remade because of errors.
Error: Process completed with exit code 1.

@avamingli
Copy link
Collaborator Author

Pushed, thanks for reviewing.

@avamingli avamingli merged commit bf7493a into cloudberrydb:main Dec 25, 2023
9 checks passed
@avamingli avamingli deleted the recover_external_fts_case branch December 25, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants