Fix: may cause UAF problem in get_size_from_segDBs #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avamingli
reviewed
Dec 7, 2023
avamingli
approved these changes
Dec 8, 2023
|
LGTM. |
In function `get_size_from_segDBs`, If the cdb result returned from segment is not as expected. Then we will clear up the cdb call the ereport. But in this cause the value in cdb result have been freed. We should keep a cdb result before cleanup it.
jiaqizho
force-pushed
the
fix-uaf-in-udf-get-size-from-segs
branch
from
37284ab
to
0924717
Compare
|
Pushed, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #NO_ISSUE_NUMBER
Change logs
nope
Why are the changes needed?
In function
get_size_from_segDBs, If the cdb result returned from segment is not as expected. Then we will clear up the cdb call the ereport. But in this cause the value in cdb result have been freed. We should keep a cdb result before cleanup it.Does this PR introduce any user-facing change?
nope
How was this patch tested?
nope
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready馃コ