Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose some functions to support PAX for partition tables #328

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

gfphoenix78
Copy link
Collaborator

  1. ComputePartitionAttrs: expose function
  2. transformPartitionBound: add argument of PartitionKey
  3. transformPartitionRangeBounds: add argument of PartitionKey
  4. list_sort_arg: sort the List with context argument in cmp function

No behavior changes, no test.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready馃コ

1. ComputePartitionAttrs: expose function
2. transformPartitionBound: add argument of PartitionKey
3. transformPartitionRangeBounds: add argument of PartitionKey
4. list_sort_arg: sort the List with context argument in cmp function
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit a6a1992 into cloudberrydb:main Dec 12, 2023
9 checks passed
@gfphoenix78 gfphoenix78 deleted the expose-functions branch December 15, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants