-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature encoding option for custom table AM #343
Merged
gfphoenix78
merged 4 commits into
cloudberrydb:main
from
gfphoenix78:feature-encoding-option
Dec 28, 2023
Merged
Feature encoding option for custom table AM #343
gfphoenix78
merged 4 commits into
cloudberrydb:main
from
gfphoenix78:feature-encoding-option
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfphoenix78
force-pushed
the
feature-encoding-option
branch
from
December 20, 2023 16:47
cbb9e53
to
794087b
Compare
gfphoenix78
commented
Dec 21, 2023
gfphoenix78
commented
Dec 21, 2023
gfphoenix78
commented
Dec 21, 2023
gfphoenix78
commented
Dec 21, 2023
gfphoenix78
commented
Dec 21, 2023
gfphoenix78
force-pushed
the
feature-encoding-option
branch
2 times, most recently
from
December 27, 2023 01:08
5a5004b
to
657a8d9
Compare
gfphoenix78
changed the title
WIP: Feature encoding option
Feature encoding option for custom table AM
Dec 27, 2023
This commit supports custom table AM to have its own encoding options. The kernal has hard-coded encoding clause for AOCO. The guc gp_default_storage_options is only considered by AOCO, because the options may be different for other table AM.
avamingli
reviewed
Dec 27, 2023
avamingli
approved these changes
Dec 27, 2023
gfphoenix78
force-pushed
the
feature-encoding-option
branch
from
December 28, 2023 05:01
657a8d9
to
c0aec6f
Compare
avamingli
approved these changes
Dec 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheck
make -C src/test installcheck-cbdb-parallel
cloudberrydb/dev
team for review and approval when your PR is ready馃コ