Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compile error that pipe is redefined #349

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Fix compile error that pipe is redefined #349

merged 1 commit into from
Jun 6, 2024

Conversation

gfphoenix78
Copy link
Collaborator

pipe is pre-declared as a function in system library. But, the source code in pipe.c re-define this symbol as a new type. It should be fine normally. But this behavior will cause an error in some environments, so rename this type name.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready馃コ

@gfphoenix78 gfphoenix78 changed the title Fix compile error that warns pipe is redefined Fix compile error that pipe is redefined Dec 26, 2023
@avamingli
Copy link
Collaborator

Hi, GPDB has fixed it in https://github.com/greenplum-db/gpdb/pull/13938

my-ship-it
my-ship-it approved these changes Dec 27, 2023
View reviewed changes
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it
Copy link
Contributor

Please cherry pick: https://github.com/greenplum-db/gpdb/pull/13938 ?

@gfphoenix78
Fix compile error that warns pipe is redefined
01a6c40 
`pipe` is pre-declared as a function in system library. But,
the source code in pipe.c re-define this symbol as a new type.
It should be fine normally. But this behavior will cause an
error in some environments, so rename this type name.
@my-ship-it my-ship-it merged commit ccfdc18 into cloudberrydb:main Jun 6, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@my-ship-it my-ship-it my-ship-it approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gfphoenix78 @avamingli @my-ship-it