change MAX_TARABLE_SYMLINK_PATH_LENGTH to 200
#350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hiiii, @shmiwy welcome!馃帄 Thanks for taking the effort to make our project better! 馃檶 Keep making such awesome contributions!
|
Please fix CI failures. |
Symlink targets currently have a length limit of 100, which may not be sufficient in many test cases, so we change it to 200 here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlink targets currently have a length limit of 100, which may not be sufficient in many test cases, so we change it to 200 here.
Change logs
change MAX_TARABLE_SYMLINK_PATH_LENGTH to 200
Why are the changes needed?
In many test cases, we found that the 100 limit was not enough.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready馃コ