Add guc gp_enable_explain_motion_detail to show sender time when Expl… #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ain Analyse. gp_enable_explain_motion_detail default to off. Signed-off-by: Dongxiao Song <songdongxiao@hashdata.cn>
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hiiii, @songdongxiaoa2 welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show motion sender time when Explain Analyse.
When guc set, Explain Analyse result will be:
actual time=<receive_start>..<receive_end>/<sender_start>..<sender_end>
gp_enable_explain_motion_detail defaults to off.
Change logs
QEs will now send Motion Sender instruments to QD.
QD will collect two instruments(sender and receiver) to MotionPlanState->instruments[].
Add guc gp_enable_explain_motion_detail to show sender time.
Add test cases.
Why are the changes needed?
In plan on QD, Motion is a single node, so we need an array of two to collect both sender and receiver instruments.
Add guc to show this information only when needed.
Does this PR introduce any user-facing change?
Yes, the guc gp_enable_explain_motion_detail default to off. Show sending time by:
set gp_enable_explain_motion_detail to on
in client.
How was this patch tested?
Added icw test case and passed in local.
Contributor's Checklist