Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix greenplum_path.sh change PATH #363

Closed
wants to merge 1 commit into from
Closed

Fix greenplum_path.sh change PATH #363

wants to merge 1 commit into from

Conversation

Ray-Eldath
Copy link
Contributor

Now only override PATH when Python used during ./configure isn't included in.

@Ray-Eldath
Fix greenplum_path.sh change PATH
8bc4e2d 
Now only override PATH when Python used during ./configure isn't included in.
yjhjstz
yjhjstz reviewed Jan 20, 2024
View reviewed changes
gpMgmt/bin/generate-greenplum-path.sh
EOF

cat <<"EOF"
PYTHONPATH="${GPHOME}/lib/python"
PATH="${GPHOME}/bin:${PYTHONBINDIR}:${PATH}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can put $PATH in front ? like PATH="${PATH}:${GPHOME}/bin:${PYTHONBINDIR}"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably no. The system psql like commands(comes from the standard postgres) will have higher precedence over the commands in cbdb.

@gfphoenix78
Copy link
Collaborator

@Ray-Eldath Could you describe what's wrong in the current greenplum_path.sh?

@Ray-Eldath
Copy link
Contributor Author

Current greenplum_path.sh is a result of #201 to make greenplum_path.sh always using the Python during ./configure.

But it introduced unnecessary changes to user's $PATH. Colleagues reported that they use multiple gcc toolchain versions, and source greenplum.sh accidently changes gcc version that they're using greenplum_path.sh because #201 changes $PATH.

I think we could just revert this portion of #201 for the sake of simplicity.

@Ray-Eldath Ray-Eldath closed this Feb 23, 2024
@Ray-Eldath Ray-Eldath deleted the fix-greenplum_path branch February 23, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjhjstz yjhjstz yjhjstz left review comments

@gfphoenix78 gfphoenix78 gfphoenix78 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ray-Eldath @gfphoenix78 @yjhjstz