Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AO/AOCS insertDesc memory issue. #365

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

avamingli
Copy link
Collaborator

This is introduced by 9ce6ab6.
The insertDesc should be inside AO/AOCS's stateCxt itself. Else when switching to aonther insertDesc due to multiple insert seg files, memory corrupt will happen.

Authored-by: Zhang Mingli avamingli@gmail.com

fix #ISSUE_Number


Change logs

Describe your change clearly, including what problem is being solved or what feature is being added.

If it has some breaking backward or forward compatibility, please clary.

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready馃コ

@avamingli
Copy link
Collaborator Author

Fix #364

@avamingli avamingli requested a review from shmiwy January 12, 2024 03:23
@avamingli
Copy link
Collaborator Author

Test with files in #364 , and case passes, @shmiwy could you help to confirm again, thanks.

This is introduced by 9ce6ab6.
The insertDesc should be inside AO/AOCS's stateCxt itself.
Else when switching to aonther insertDesc due to multiple
insert seg files, memory corrupt will happen.

Authored-by: Zhang Mingli avamingli@gmail.com
Copy link
Contributor

@my-ship-it my-ship-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avamingli avamingli merged commit e4f5a01 into cloudberrydb:main Jan 12, 2024
9 checks passed
@avamingli avamingli deleted the fix_ao_mem branch January 12, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants