Extend a new AM method to do acquire sample rows. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenchaozhang-123
requested review from
gongxun0928,
my-ship-it and
gfphoenix78
my-ship-it
reviewed
Jan 29, 2024
wenchaozhang-123
force-pushed
the
fix_analyze
branch
2 times, most recently
from
890a5c2
to
9234cb5
Compare
wenchaozhang-123
force-pushed
the
fix_analyze
branch
5 times, most recently
from
2b2fbc0
to
9fc2dd2
Compare
my-ship-it
reviewed
Feb 1, 2024
my-ship-it
reviewed
Feb 1, 2024
wenchaozhang-123
force-pushed
the
fix_analyze
branch
from
8af4638
to
b0e2b79
Compare
gfphoenix78
reviewed
Feb 4, 2024
wenchaozhang-123
force-pushed
the
fix_analyze
branch
9 times, most recently
from
af194f3
to
880e232
Compare
wenchaozhang-123
force-pushed
the
fix_analyze
branch
from
880e232
to
8fc2546
Compare
As diffenrent storage formats maybe need different process when acquire sample rows. To support this conviniently, we extend a new AM method interface called acquire_sample_rows in TableAmRoutine. authored-by: Zhang Wenchao zwcpostgres@gmail.com
wenchaozhang-123
force-pushed
the
fix_analyze
branch
from
8fc2546
to
8c62435
Compare
gfphoenix78
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready馃コ