Feature: extend int128 to numeric interface #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiaqizho
force-pushed
the
feature-extend-numeric
branch
from
f2f97e8
to
26df32a
Compare
jiaqizho
force-pushed
the
feature-extend-numeric
branch
from
26df32a
to
f6acd00
Compare
my-ship-it
reviewed
Mar 5, 2024
| @@ -4423,6 +4424,41 @@ int64_to_numeric(int64 val) | |||
| return res; | |||
| } | |||
|
|
|||
| #ifdef HAVE_INT128 | |||
| Numeric | |||
| int128_to_numeric(int128 val, int scale, bool neg, | |||
There was a problem hiding this comment.
No need to change in numeric.c?
|
after #392 , no need current change any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #ISSUE_Number
Change logs
CBDB not allow building pg numeric from other formats. Numeric objects can only be constructed from string, which means that the caller needs to convert its own data into a specific format string, then convert the string into numeric. This is a very inefficient method.
Current change provider a new method
int128_to_numericwhich used to build a numeric from int128. Also, current method allow build special numeric or build numeric with scale.Why are the changes needed?
Allow caller build numeric from int128
Does this PR introduce any user-facing change?
nope
How was this patch tested?
ci
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready馃コ