Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Use amflags to support Column-oriented scanning of custom ta… #407

Conversation

gongxun0928
Copy link
Contributor

@gongxun0928 gongxun0928 commented Apr 11, 2024

fix #ISSUE_Number


Change logs

For custom tableam, maybe it support column-oriented scanning, the postgres planner can no longer use whether am_handler is aocs table_am to decide whether only to add the columns required by the operator to the targetlist.

If table am supports column-oriented scanning, the flags returned by set_flags set the SCAN_SUPPORT_COLUMN_ORIENTED_SCAN bit.

Why are the changes needed?

I hope that custom column storage can also scan only necessary columns, instead of only aocs table am support

Does this PR introduce any user-facing change?

no

How was this patch tested?

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


GongXun seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gongxun0928 gongxun0928 force-pushed the feature/use-amflags-to-support-column-oriented-scanning-of-custom-tableam branch 2 times, most recently from c9d0a10 to 67e15e8 Compare April 11, 2024 05:49
…bleam

For custom tableam, maybe it support column-oriented scanning, the postgres
planner can no longer use whether am_handler is aocs handler to decide
whether only to add the columns required by the operator to the targetlist,
but use amflags to determine

If table am supports column-oriented scanning, the flags returned by set_flags
will set the SCAN_SUPPORT_COLUMN_ORIENTED_SCAN bit.
@gongxun0928 gongxun0928 force-pushed the feature/use-amflags-to-support-column-oriented-scanning-of-custom-tableam branch from 67e15e8 to 43860ff Compare April 11, 2024 07:38
Copy link
Collaborator

@gfphoenix78 gfphoenix78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@my-ship-it my-ship-it merged commit 7c0423c into cloudberrydb:main Apr 11, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants