Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace gpscp with gpsync in ext fts #470

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Jun 17, 2024

Change logs

After commit 2ff7b0c, CBDB replaced gpscp with gpsync, but without change the external FTS logic.

Also looks like CI(icw-external-fts) using the wrong package .

Why are the changes needed?

Describe why the changes are necessary.

Does this PR introduce any user-facing change?

If yes, please clarify the previous behavior and the change this PR proposes.

How was this patch tested?

Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.

Contributor's Checklist

Here are some reminders and checklists before/when submitting your pull request, please check them:

  • Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
  • Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
  • Learn the coding contribution guide, including our code conventions, workflow and more.
  • List your communication in the GitHub Issues or Discussions (if has or needed).
  • Document changes.
  • Add tests for the change
  • Pass make installcheck
  • Pass make -C src/test installcheck-cbdb-parallel
  • Feel free to request cloudberrydb/dev team for review and approval when your PR is ready🥳

Copy link
Collaborator

@avamingli avamingli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@my-ship-it my-ship-it merged commit e1d276f into cloudberrydb:main Jun 18, 2024
10 checks passed
foreyes pushed a commit to foreyes/cloudberrydb that referenced this pull request Jul 8, 2024
After commit 2ff7b0c, CBDB replaced gpscp with gpsync, but without change the external FTS logic.
Also looks like CI(icw-external-fts) using the wrong package .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants