LITE-29965 add storybook support for vite, upgrade to storybook 8 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
paulinaczybir
commented
May 6, 2024
•
paulinaczybir
commented
- upgrade Storybook to version 8
- figma design is now included in story not in MDX file
- add stories.css to keep stories styles there
- delete MDX files for different icon types (it wasn't possible anymore to render Vue component in MDX) and replace them with separate story for each types of icon, it's not ideal but at least we can check all available icons
- delete multiple not needed dependencies
- IMPORTANT: after moving to use vite the loading time of storybook components (initial load )slowed down significantly and I didn't find any way to improve that yet
paulinaczybir
force-pushed
the
LITE-29965-storybook-to-work-with-vite
branch
from
b9ea51e
to
01f40d0
Compare
paulinaczybir
changed the title
nerimartinez
approved these changes
May 7, 2024
arnaugiralt
merged commit 500a5d5
into
feature/LITE-29730-migrate-to-esm-and-from-webpack-to-vite
3 of 4 checks passed
paulinaczybir
pushed a commit
that referenced
this pull request
May 9, 2024
…th-vite LITE-29965 add storybook support for vite, upgrade to storybook 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.