Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LITE-18627 Added prefetch count for RabbitMQ #39

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

net-free
Copy link
Collaborator

@net-free net-free commented Jun 4, 2021

No description provided.

@net-free net-free requested review from d3rky, maxipavlovic, marcserrat and a user June 4, 2021 09:53
@net-free net-free force-pushed the lite-18627-rabbitmq-prefetch-count branch from 87fde95 to 13e9bbe Compare June 4, 2021 10:22
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2021

Codecov Report

Merging #39 (13e9bbe) into master (e73f923) will decrease coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   95.63%   95.59%   -0.04%     
==========================================
  Files          31       31              
  Lines        1649     1658       +9     
==========================================
+ Hits         1577     1585       +8     
- Misses         72       73       +1     
Impacted Files Coverage Δ
dj_cqrs/transport/rabbit_mq.py 85.83% <71.42%> (+0.06%) ⬆️
dj_cqrs/utils.py 93.54% <87.50%> (-6.46%) ⬇️
dj_cqrs/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73f923...13e9bbe. Read the comment docs.

dj_cqrs/utils.py Outdated Show resolved Hide resolved
@net-free net-free force-pushed the lite-18627-rabbitmq-prefetch-count branch from 13e9bbe to 0630190 Compare June 7, 2021 09:42
@d3rky
Copy link
Contributor

d3rky commented Jun 7, 2021

Tests are passed - some issues with uploading coverage

@d3rky d3rky merged commit c69c81f into master Jun 7, 2021
@Szejdi
Copy link

Szejdi commented Nov 17, 2021

Hey,

I've found that this Pull Request is breaking cqrs_dead_letters retry command.

_get_consumer_settings used to return 2 arguments and with this change it start to return tuple of 3,
which is breaking init_broker method in above mentioned command.
Exact line:

queue_name, dead_letter_queue_name = RabbitMQTransportService.get_consumer_settings()

is raising ValueError: too many values to unpack (expected 2)

@maxipavlovic
Copy link
Member

@Szejdi thank you very much. We will fix that!

@maxipavlovic
Copy link
Member

@Szejdi fixed in 1.13.2

@maxipavlovic maxipavlovic deleted the lite-18627-rabbitmq-prefetch-count branch May 12, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants