Stop nodes from jiggling at the edges when the graph is being built. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PamelaM
commented
Mar 14, 2018
| @@ -24,6 +24,7 @@ var LINK_RANDOM = 100; | |||
| var LINK_MIN_OFFSET = 25; | |||
| var RIM_SIZE = 15; | |||
| var NODE_SIZE = 150; | |||
| var MARGIN = NODE_SIZE / 2 / 2; | |||
There was a problem hiding this comment.
This is a constant that was being re-calculated regularly, moved it here.
PamelaM
commented
Mar 14, 2018
| var delta = 1; | ||
|
|
||
| // Make sure that all nodes remain within the top and bottom edges | ||
| // of the display area |
There was a problem hiding this comment.
Rename variables, use the MARGIN constant.
PamelaM
commented
Mar 14, 2018
| if (d.y < y1) d.y += delta; | ||
| if (d.y > y2) d.y -= delta; | ||
| }); | ||
| d.x = largest(min_x, smallest(max_x, d.x)) |
There was a problem hiding this comment.
This is the main fix
PamelaM
commented
Mar 14, 2018
| @@ -863,7 +864,7 @@ function onNodeMouseOver(node) { | |||
|
|
|||
| $('g.node').each(function(i, e) { | |||
| if (e.__data__ == node) { | |||
| $e = $(e); | |||
There was a problem hiding this comment.
This fixes an unrelated console error message
PamelaM
commented
Mar 14, 2018
| @@ -16,3 +16,5 @@ export const radial = (point: Point, radius: number, radians: number): Point => | |||
| y: Math.sin(radians) * radius + point.y | |||
| }) | |||
|
|
|||
| export const smallest = (a : number, b : number): number => a < b ? a : b | |||
There was a problem hiding this comment.
Two simple helper functions to make code readable
|
looks good to me! thanks for this, pam. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the force-directed-graph nodes bumped up against the edges of the display area, they would "jiggle" very unpleasantly. This was due to a poor algorithm that tried to nudge the nodes back towards the inside of the area.
Instead, we now just push nodes back into the display if they try to drift outside of it.