feat: added sg description

clouddrove · Jun 12, 2023 · 9b1ade1 · 9b1ade1
1 parent 5a0cf3a
commit 9b1ade1
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 12 deletions.
diff --git a/_example/memcached/example.tf b/_example/memcached/example.tf
@@ -74,9 +74,11 @@ module "memcached" {
   ####----------------------------------------------------------------------------------
   ## will create ROUTE-53 for redis which will add the dns of the cluster.
   ####----------------------------------------------------------------------------------
-  dns_record_name = "prod"
-  route53_ttl     = "300"
-  route53_type    = "CNAME"
-  route53_zone_id = "FTOFGXXXXDFDFF"
+  route53_record_enabled         = false
+  ssm_parameter_endpoint_enabled = false
+  dns_record_name                = "prod"
+  route53_ttl                    = "300"
+  route53_type                   = "CNAME"
+  route53_zone_id                = "SERFxxxx6XCsY9Lxxxxx"
 
 }
diff --git a/_example/redis-cluster/example.tf b/_example/redis-cluster/example.tf
@@ -75,10 +75,10 @@ module "redis-cluster" {
   ####----------------------------------------------------------------------------------
   ## will create ROUTE-53 for redis which will add the dns of the cluster.
   ####----------------------------------------------------------------------------------
-  ssm_parameter_endpoint_enabled = true
-  route53_record_enabled         = true
+  route53_record_enabled         = false
+  ssm_parameter_endpoint_enabled = false
   dns_record_name                = "prod"
   route53_ttl                    = "300"
   route53_type                   = "CNAME"
-  route53_zone_id                = "Z0xxxx16XCxxxxxxx4"
+  route53_zone_id                = "SERFxxxx6XCsY9Lxxxxx"
 }
diff --git a/_example/redis/example.tf b/_example/redis/example.tf
@@ -91,8 +91,8 @@ module "redis" {
   ####----------------------------------------------------------------------------------
   ## will create ROUTE-53 for redis which will add the dns of the cluster.
   ####----------------------------------------------------------------------------------
-  route53_record_enabled         = true
-  ssm_parameter_endpoint_enabled = true
+  route53_record_enabled         = false
+  ssm_parameter_endpoint_enabled = false
   dns_record_name                = "prod"
   route53_ttl                    = "300"
   route53_type                   = "CNAME"

diff --git a/main.tf b/main.tf
@@ -42,7 +42,7 @@ data "aws_security_group" "existing" {
 resource "aws_security_group_rule" "egress" {
   count = (var.enable_security_group == true && length(var.sg_ids) < 1 && var.is_external == false && var.egress_rule == true) ? 1 : 0
 
-  description = var.sg_egress_description
+  description       = var.sg_egress_description
   type              = "egress"
   from_port         = 0
   to_port           = 65535
@@ -54,7 +54,7 @@ resource "aws_security_group_rule" "egress" {
 resource "aws_security_group_rule" "egress_ipv6" {
   count = (var.enable_security_group == true && length(var.sg_ids) < 1 && var.is_external == false) && var.egress_rule == true ? 1 : 0
 
-  description = var.sg_egress_description
+  description       = var.sg_egress_ipv6_description
   type              = "egress"
   from_port         = 0
   to_port           = 65535
@@ -65,7 +65,7 @@ resource "aws_security_group_rule" "egress_ipv6" {
 resource "aws_security_group_rule" "ingress" {
   count = length(var.allowed_ip) > 0 == true && length(var.sg_ids) < 1 ? length(compact(var.allowed_ports)) : 0
 
-  description = var.sg_egress_description
+  description       = var.sg_ingress_description
   type              = "ingress"
   from_port         = element(var.allowed_ports, count.index)
   to_port           = element(var.allowed_ports, count.index)

diff --git a/variables.tf b/variables.tf
@@ -381,6 +381,18 @@ variable "sg_egress_description" {
   description = "Description of the egress and ingress rule"
 }
 
+variable "sg_egress_ipv6_description" {
+  type        = string
+  default     = "Description of the rule."
+  description = "Description of the egress_ipv6 rule"
+}
+
+variable "sg_ingress_description" {
+  type        = string
+  default     = "Description of the ingress rule use elasticache."
+  description = "Description of the ingress rule"
+}
+
 ##---------------------route53------------------------
 variable "route53_record_enabled" {
   type        = bool