Skip to content

Commit

Permalink
Collect hs_err_pid*.log files in logs/
Browse files Browse the repository at this point in the history
These JVM error dumps are often useful for debugging job failures. We
should put them into the logs/ directory so they can be collected
along with other logs.

This was motivated by IMPALA-7069.

Testing:
Induced a segfault by changing the code, checked that the file ended up
in the logs/ subdirectory.

==C5_APPROVED_BUGFIX==

Change-Id: I753f6acb63cec600432675cfb6e5dd1e1427b5ae
Reviewed-on: http://gerrit.cloudera.org:8080/10594
Reviewed-by: Lars Volker <lv@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
(cherry picked from commit ac301f7)
  • Loading branch information
Tim Armstrong authored and glglwty committed Aug 1, 2018
1 parent 308a93a commit 7e9604f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions bin/impala-config.sh
Expand Up @@ -528,6 +528,8 @@ export USER="${USER-`id -un`}"
# TODO: figure out how to turn this off only the stuff that can't run with it.
#LIBHDFS_OPTS="-Xcheck:jni -Xcheck:nabounds"
export LIBHDFS_OPTS="${LIBHDFS_OPTS:-} -Djava.library.path=${HADOOP_LIB_DIR}/native/"
LIBHDFS_OPTS+=" -XX:ErrorFile=${IMPALA_LOGS_DIR}/hs_err_pid%p.log"


# IMPALA-5080: Our use of PermGen space sometimes exceeds the default maximum while
# running tests that load UDF jars.
Expand Down

0 comments on commit 7e9604f

Please sign in to comment.