Skip to content

Commit

Permalink
IMPALA-3223: Relocate squeasel and mustache directories
Browse files Browse the repository at this point in the history
This change moves the source and header files of squeasel
and mustache to be/src/thirdparty. This is a step towards
removing thirdparty as a preparation to move to ASF.

There is also corresponding change to Impala-lzo to update
its include path.

Change-Id: I782e493bc28086a1587274b3c474ea6b6f201855
Reviewed-on: http://gerrit.cloudera.org:8080/3206
Reviewed-by: Michael Ho <kwho@cloudera.com>
Tested-by: Michael Ho <kwho@cloudera.com>
  • Loading branch information
Michael Ho committed May 27, 2016
1 parent 7ccb295 commit 97029cd
Show file tree
Hide file tree
Showing 12 changed files with 10 additions and 66 deletions.
8 changes: 0 additions & 8 deletions CMakeLists.txt
Expand Up @@ -191,14 +191,6 @@ else()
set(HDFS_LIB HDFS_STATIC)
endif()

# find the Squeasel webserver library
find_package(Squeasel REQUIRED)
include_directories(${SQUEASEL_INCLUDE_DIR})

# find the Mustache template library
find_package(Mustache REQUIRED)
include_directories(${MUSTACHE_INCLUDE_DIR})

# find GLog headers and libs. Must include glog headers before the other
# google libraries. They all have a config.h and we want glog's to be picked
# up first.
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
3 changes: 3 additions & 0 deletions be/src/util/CMakeLists.txt
Expand Up @@ -12,6 +12,9 @@
# See the License for the specific language governing permissions and
# limitations under the License.

set(SQUEASEL_SRC_DIR "${CMAKE_SOURCE_DIR}/be/src/thirdparty/squeasel")
set(MUSTACHE_SRC_DIR "${CMAKE_SOURCE_DIR}/be/src/thirdparty/mustache")

# Without this option Squeasel looks up the SSL library at run-time
# and may not guess the correct name on some distributions
SET_SOURCE_FILES_PROPERTIES(${SQUEASEL_SRC_DIR}/squeasel.c PROPERTIES
Expand Down
8 changes: 4 additions & 4 deletions be/src/util/webserver.cc
Expand Up @@ -20,18 +20,19 @@
#include <boost/lexical_cast.hpp>
#include <boost/mem_fn.hpp>
#include <boost/thread/locks.hpp>
#include <fstream>
#include <gutil/strings/substitute.h>
#include <map>
#include <fstream>
#include <stdio.h>
#include <signal.h>
#include <string>
#include <mustache/mustache.h>
#include <rapidjson/stringbuffer.h>
#include <rapidjson/prettywriter.h>

#include "util/asan.h"
#include "common/logging.h"
#include "rpc/thrift-util.h"
#include "thirdparty/mustache/mustache.h"
#include "util/asan.h"
#include "util/cpu-info.h"
#include "util/disk-info.h"
#include "util/mem-info.h"
Expand All @@ -42,7 +43,6 @@
#include "util/debug-util.h"
#include "util/pretty-printer.h"
#include "util/stopwatch.h"
#include "rpc/thrift-util.h"

#include "common/names.h"

Expand Down
6 changes: 3 additions & 3 deletions be/src/util/webserver.h
Expand Up @@ -16,14 +16,14 @@
#ifndef IMPALA_UTIL_WEBSERVER_H
#define IMPALA_UTIL_WEBSERVER_H

#include <squeasel/squeasel.h>
#include <string>
#include <map>
#include <boost/function.hpp>
#include <boost/thread/shared_mutex.hpp>
#include <map>
#include <rapidjson/document.h>
#include <string>

#include "common/status.h"
#include "thirdparty/squeasel/squeasel.h"
#include "util/network-util.h"

namespace impala {
Expand Down
26 changes: 0 additions & 26 deletions cmake_modules/FindMustache.cmake

This file was deleted.

25 changes: 0 additions & 25 deletions cmake_modules/FindSqueasel.cmake

This file was deleted.

0 comments on commit 97029cd

Please sign in to comment.