Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT-709: Added pre-commit hook for static analysis and formatting changes for coding standards #103

Merged
merged 1 commit into from
Jul 10, 2023
Merged

DBT-709: Added pre-commit hook for static analysis and formatting changes for coding standards #103

merged 1 commit into from
Jul 10, 2023

Conversation

niteshy
Copy link
Collaborator

@niteshy niteshy commented Jun 17, 2023 •
edited
Loading

Describe your changes

  • Added .pre-commit-config.yaml to add git hooks on commit
  • Update Makefile as pre-commit commands
  • Rest of the files are the formatting changes because of pre-commit hooks

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-709

Testing procedure/screenshots(if appropriate):

https://gist.github.com/niteshy/242b72cd877d765e13dff76732db8135

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@niteshy niteshy self-assigned this Jun 18, 2023
@niteshy niteshy added the enhancement New feature or request label Jun 18, 2023
vamshikolanu
vamshikolanu previously approved these changes Jul 10, 2023
View reviewed changes
DBT-709: Added pre-commit hook for static analysis and formatting cha…
31c7146 
…nges for coding standards

(cherry picked from commit 42b8aa3)
@niteshy niteshy dismissed vamshikolanu’s stale review July 10, 2023 19:29

The merge-base changed after approval.

@niteshy niteshy merged commit 4393e94 into main Jul 10, 2023
@niteshy niteshy deleted the pre-commit branch July 24, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vamshikolanu vamshikolanu vamshikolanu left review comments

Assignees

@niteshy niteshy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niteshy @vamshikolanu