Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBT-688: Fix default value of incremental_strategy. #164

Merged
merged 1 commit into from May 2, 2023

Conversation

vamshikolanu
Copy link
Collaborator

@vamshikolanu vamshikolanu commented May 2, 2023

Describe your changes

config.get() default value is not working as expected. It's returning None instead of taking the default value as append. Hence explicitly setting the default incremental_strategy value to append

Internal Jira ticket number or external issue link

https://jira.cloudera.com/browse/DBT-688

Testing procedure/screenshots(if appropriate):

basic tests: https://gist.github.com/vamshikolanu/be58a8b74b7fd2fac02e20301e892722
insert overwrite test (verbose): https://gist.github.com/vamshikolanu/7bd533a6178f836501dfb61d36ba15d5
append test (verbose): https://gist.github.com/vamshikolanu/f2ebf2a4d4a309417ae465d0ce65b76a

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have formatted my added/modified code to follow pep-8 standards
  • I have checked suggestions from python linter to make sure code is of good quality.

@vamshikolanu vamshikolanu changed the title fix_insert_overwrite DBT-688: Fix default value of incremental_strategy. May 2, 2023
Copy link
Collaborator

@niteshy niteshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vamshikolanu vamshikolanu merged commit a126fc3 into master May 2, 2023
@niteshy niteshy deleted the fix_insert_overwrite_one branch May 5, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants