[slack] Add Sharing from Editor config flag (#2031)

* [slack] Add share_from_editor config flag - Secondary feature flag to switch on/off direct sharing from within Hue Editor UI to Slack
cloudera · Apr 21, 2021 · 1996889 · 1996889
1 parent c9c885b
commit 1996889
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 20 deletions.
diff --git a/desktop/conf.dist/hue.ini b/desktop/conf.dist/hue.ini
@@ -826,6 +826,9 @@
     # Enables Slack application API endpoints
     ## is_enabled=true
 
+    # Enables direct sharing from Editor to Slack
+    ## share_from_editor=false
+
 
   # Configuration options for the request Tracing
   # ------------------------------------------------------------------------

diff --git a/desktop/conf/pseudo-distributed.ini.tmpl b/desktop/conf/pseudo-distributed.ini.tmpl
@@ -828,6 +828,9 @@
     # Enables Slack application API endpoints
     ## is_enabled=true
 
+    # Enables direct sharing from Editor to Slack
+    ## share_from_editor=false
+
 
   # Configuration options for the request Tracing
   # ------------------------------------------------------------------------

diff --git a/desktop/core/src/desktop/conf.py b/desktop/core/src/desktop/conf.py
@@ -742,30 +742,36 @@ def get_deprecated_login_lock_out_by_combination_browser_user_agent():
       help=_('Enables Slack application API endpoints'),
       type=coerce_bool,
       default=False,
-      ),
+    ),
     SLACK_CLIENT_ID=Config(
-        key='slack_client_id',
-        type=str,
-        dynamic_default=get_slack_client_id,
-      ),
+      key='slack_client_id',
+      type=str,
+      dynamic_default=get_slack_client_id,
+    ),
     SLACK_CLIENT_SECRET=Config(
-        key='slack_client_secret',
-        type=str,
-        private=True,
-        dynamic_default=get_slack_client_secret,
-      ),
+      key='slack_client_secret',
+      type=str,
+      private=True,
+      dynamic_default=get_slack_client_secret,
+    ),
     SLACK_VERIFICATION_TOKEN=Config(
-        key='slack_verification_token',
-        type=str,
-        private=True,
-        dynamic_default=get_slack_verification_token,
-      ),
+      key='slack_verification_token',
+      type=str,
+      private=True,
+      dynamic_default=get_slack_verification_token,
+    ),
     SLACK_BOT_USER_TOKEN=Config(
-        key='slack_bot_user_token',
-        type=str,
-        private=True,
-        dynamic_default=get_slack_bot_user_token,
-      ),
+      key='slack_bot_user_token',
+      type=str,
+      private=True,
+      dynamic_default=get_slack_bot_user_token,
+    ),
+    SHARE_FROM_EDITOR=Config(
+      key='share_from_editor',
+      help=_('Enables direct sharing from Editor to Slack'),
+      type=coerce_bool,
+      default=False,
+    ),
   )
 )