Skip to content

Commit

Permalink
[ksql] Do not hardcode connector id in metadata API
Browse files Browse the repository at this point in the history
  • Loading branch information
romainr committed Jul 1, 2021
1 parent 7284f55 commit b195fb3
Showing 1 changed file with 9 additions and 2 deletions.
11 changes: 9 additions & 2 deletions desktop/libs/kafka/src/kafka/kafka_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import logging
import sys

from desktop.api_public import _get_interpreter_from_dialect
from desktop.lib.django_util import JsonResponse
from desktop.lib.i18n import force_unicode
from metadata.manager_client import ManagerApi
Expand Down Expand Up @@ -111,15 +112,21 @@ def get_topics(user):
'database': 'topics'
}

interpreter = _get_interpreter_from_dialect('ksql', user)
api = _get_notebook_api(user, connector_id=interpreter['type'])

return [
topic['name']
for topic in _get_notebook_api(user, connector_id=56).autocomplete(**data)['tables_meta']
for topic in api.autocomplete(**data)['tables_meta']
if not topic['name'].startswith('__')
]


def get_topic_data(user, name):
data = _get_notebook_api(user, connector_id=56).get_sample_data(snippet={})
interpreter = _get_interpreter_from_dialect('ksql', user)
api = _get_notebook_api(user, connector_id=interpreter['type'])

data = api.get_sample_data(snippet={})
print(data)
return data

Expand Down

0 comments on commit b195fb3

Please sign in to comment.