LIVY-257. access log is not available #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, the test failure should also be fixed. |
jerryshao
reviewed
Nov 30, 2016
| @@ -693,6 +695,7 @@ | |||
| <environmentVariables> | |||
| <LIVY_TEST>true</LIVY_TEST> | |||
| <SPARK_HOME>${spark.home}</SPARK_HOME> | |||
| <LIVY_LOG_DIR>${livy.log.dir}</LIVY_LOG_DIR> | |||
There was a problem hiding this comment.
Will this change the log output dir for integration test, previously it is under miniLivyMain.
There was a problem hiding this comment.
It is still under miniLivyMain, but the access log is under target
Current coverage is 71.92% (diff: 100%)@@ master #239 diff @@
==========================================
Files 90 90
Lines 4539 4541 +2
Methods 0 0
Messages 0 0
Branches 772 772
==========================================
+ Hits 3262 3266 +4
+ Misses 828 826 -2
Partials 449 449
|
alex-the-man
reviewed
Dec 2, 2016
| @@ -71,6 +71,8 @@ | |||
| <test.redirectToFile>true</test.redirectToFile> | |||
| <execution.root>${user.dir}</execution.root> | |||
| <spark.home>${execution.root}/dev/spark</spark.home> | |||
| <!-- used for testing, NCSARequestLog use it for access log --> | |||
| <livy.log.dir>${basedir}/target</livy.log.dir> | |||
There was a problem hiding this comment.
Nit: Mind if we keep it under MiniLivyMain for integration test?
There was a problem hiding this comment.
The reason I put it in parent is that HttpClientSpec also use WebServer.
| @@ -74,12 +72,14 @@ class WebServer(livyConf: LivyConf, var host: String, var port: Int) extends Log | |||
| val handlers = new HandlerCollection | |||
| handlers.addHandler(context) | |||
|
|
|||
| // configure the access log | |||
| // configure the access log | |||
There was a problem hiding this comment.
Nit:
// Configure the access log
alex-the-man
reviewed
Dec 2, 2016
| val requestLogHandler = new RequestLogHandler | ||
| val requestLog = new NCSARequestLog("/jetty-yyyy_mm_dd.request.log") | ||
| val requestLog = new NCSARequestLog(sys.env.getOrElse("LIVY_LOG_DIR", | ||
| sys.env("LIVY_HOME") + "/logs") + "/jetty-yyyy_mm_dd.request.log") |
There was a problem hiding this comment.
Nit: name it "yyyy_mm_dd.request.log" instead of "jetty-yyyy_mm_dd.request.log"
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward bugfix for access log file.