LIVY-273. Add Spnego support for Java/scala and Python Job API client #265
Conversation
Change-Id: I8cce80d75a549e573da70be9ef1aeb94457829a4
Current coverage is 70.61% (diff: 33.33%)@@ master #265 diff @@
==========================================
Files 92 92
Lines 4749 4768 +19
Methods 0 0
Messages 0 0
Branches 822 828 +6
==========================================
- Hits 3376 3367 -9
- Misses 899 907 +8
- Partials 474 494 +20
|
Change-Id: I022b3c14a439321deda3ae5e0cacbc2b18ef9830
jerryshao
changed the title
Change-Id: I9e9f00dde93c471c6fa1fd5f71842945f527c73b
|
I don't know much about Spnego. @zjffdu Mind if you take a look? |
|
@zjffdu , would you please help to review this PR? |
| } | ||
|
|
||
| boolean shouldEnableSpnego() { |
There was a problem hiding this comment.
rename it to isSpnegoEnabled ?
There was a problem hiding this comment.
Will update soon.
| @@ -24,6 +24,7 @@ cache: | |||
|
|
|||
| before_install: | |||
| - sudo apt-get -y install python3-pip python-dev | |||
| - sudo apt-get -y install libkrb5-dev | |||
There was a problem hiding this comment.
Is this needed for compilation ?
There was a problem hiding this comment.
It is required for installing requests-kerberos package.
| // This is needed to get Kerberos credentials from the environment, instead of | ||
| // requiring the application to manually obtain the credentials. | ||
| System.setProperty("javax.security.auth.useSubjectCredsOnly", "false"); | ||
|
|
There was a problem hiding this comment.
Now javax.security.auth.useSubjectCredsOnly is only set when spnego is enabled. While previously we set it in any case. Would this affect the non-secure mode ?
There was a problem hiding this comment.
I don't think so, this will only be honored in kerberos environment.
Change-Id: I4994122e8e28276efe4f00fc7ff8e02e0a7a6c60
|
LGTM |
No description provided.