Provide Jetty Http Request/Response Header Size Configuration #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerberos over http requires larger header sizes than the default, or the HTTP Error 413 Request entity too large will be returned. This patch increases the default for Livy to 128K and also allows this to be configurable.
Current coverage is 71.00% (diff: 81.81%)@@ master #266 diff @@
==========================================
Files 92 92
Lines 4749 4759 +10
Methods 0 0
Messages 0 0
Branches 822 822
==========================================
+ Hits 3376 3379 +3
- Misses 899 905 +6
- Partials 474 475 +1
|
jerryshao
reviewed
Jan 3, 2017
| @@ -58,6 +58,8 @@ object LivyConf { | |||
|
|
|||
| val SERVER_HOST = Entry("livy.server.host", "0.0.0.0") | |||
| val SERVER_PORT = Entry("livy.server.port", 8998) | |||
| val HTTP_REQUEST_HEADER_SIZE = Entry("livy.http.request.header.size", 131072) | |||
| val HTTP_RESPONSE_HEADER_SIZE = Entry("livy.http.response.header.size", 131072) | |||
There was a problem hiding this comment.
Can we rename the configurations to "livy.server.request_header.size" and "livy.server.response_header.size", also it would be better to add some comments for these two configurations to describe why we have to change the default size.
There was a problem hiding this comment.
livy.server.request-header.size
livy.server.response-header.size
jerryshao
reviewed
Jan 3, 2017
|
|
||
| case Some(keystore) => | ||
| val https = new HttpConfiguration() | ||
| https.setRequestHeaderSize(requestHeaderSize) | ||
| https.setResponseHeaderSize(responseHeaderSize) |
There was a problem hiding this comment.
Can we move this HttpConfiguration to above to remove the duplications.
|
Mind if you create a JIRA for this? |
|
@brockn Would you mind addressing the comments mentioned above? |
|
@brockn Any update ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kerberos over http requires larger header sizes than the default,
or the HTTP Error 413 Request entity too large will be returned.
This patch increases the default for Livy to 128K and also allows
this to be configurable.