Add configuration options for TLS cipher suites and protocol version #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddlipcon
reviewed
Aug 15, 2017
squeasel.c
Outdated
| if (sq_strcasecmp(ssl_version, "tlsv1") == 0) { | ||
| // No-op - don't exclude any TLS protocols. | ||
| #if OPENSSL_VERSION_NUMBER >= OPENSSL_VERSION_HAS_TLS_1_1 | ||
| } else if (sq_strcasecmp(ssl_version, "tlsv1_1") == 0) { |
There was a problem hiding this comment.
in Kudu we have a similar config but we use '.' instead of '_' in the string. ie this would be "tlsv1.1" instead of "tlsv1_1". Do you mind doing the same for consistency?
squeasel.c
Outdated
| @@ -4251,6 +4271,13 @@ static int set_ssl_option(struct sq_context *ctx) { | |||
| (void) SSL_CTX_use_certificate_chain_file(ctx->ssl_ctx, pem); | |||
| } | |||
|
|
|||
| if (ctx->config[SSL_CIPHERS] != NULL) { | |||
| if (SSL_CTX_set_cipher_list(ctx->ssl_ctx, ctx->config[SSL_CIPHERS]) == 0) { | |||
There was a problem hiding this comment.
nit: combine two lines into a single if?
|
Done for both of these. I'll update the commit msg as well, just realised that needs doing. |
toddlipcon
approved these changes
Aug 15, 2017
* ssl_min_version (one of "TLSv1", "TLSv1.1" or "TLSv1.2") controls the minimum TLS version allowed to connect to the webserver when SSL is enabled. * ssl_ciphers is a whitelist of cipher suites, in OpenSSL format. If not set the system default cipher suites are enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl_min_version (one of "TLSv1", "TLSv1_1" or "TLSv1_2") controls the
minimum TLS version allowed to connect to the webserver when SSL is
enabled.
ssl_ciphers is a whitelist of cipher suites, in OpenSSL format. If not
set the system default cipher suites are enabled.