Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudevents diff not working as expected #26

Open
1 of 3 tasks
n3wscott opened this issue Mar 8, 2022 · 1 comment
Open
1 of 3 tasks

cloudevents diff not working as expected #26

n3wscott opened this issue Mar 8, 2022 · 1 comment

Comments

@n3wscott
Copy link
Member

n3wscott commented Mar 8, 2022 •
edited
Loading

  • cloudevents diff should fail if expected is not found in the diff even for --ignore-additional
  • cloudevents diff want got should keep searching for a valid pass for each want in got. At the moment it tests and fails on the first match based on --find, but got could have more than one match.
  • cloudevents diff want got should mark got's list as "used" as it works through all the wants.

the third point is interesting. It is not clear how much shuffling we really want to produce. It is a bit of the greedy matching problem in regex.
@n3wscott n3wscott mentioned this issue Mar 11, 2022
Merged
@friedrichwilken
Copy link

@n3wscott can you help me to reproduce the first point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@n3wscott @friedrichwilken