-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JsonEventFormatter not respecting "WriteIndented" flag #225
Comments
I'm on holiday at the moment - I'll look at this on Monday. |
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Aug 1, 2022
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Aug 1, 2022
…onsoft.Json This is the Json.NET equivalent of cloudevents#225. Note that not every option in JsonTextWriter is supported; in the future we could potentially introduce some alternative approach to provide more flexibility.
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Aug 2, 2022
…ext.Json Fixes cloudevents#225 Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Aug 2, 2022
…onsoft.Json This is the Json.NET equivalent of cloudevents#225. Note that not every option in JsonTextWriter is supported; in the future we could potentially introduce some alternative approach to provide more flexibility. Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
added a commit
that referenced
this issue
Aug 5, 2022
…onsoft.Json This is the Json.NET equivalent of #225. Note that not every option in JsonTextWriter is supported; in the future we could potentially introduce some alternative approach to provide more flexibility. Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
Merged
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
added a commit
to jskeet/sdk-csharp
that referenced
this issue
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([cloudevents#236](cloudevents#236)) - Feature: Allow empty payloads in Kafka ([cloudevents#224](cloudevents#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([cloudevents#234](cloudevents#234), part of [cloudevents#231](cloudevents#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([cloudevents#226](cloudevents#226), fixes [cloudevents#225](cloudevents#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([cloudevents#220](cloudevents#220), fixes [cloudevents#219](cloudevents#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([cloudevents#222](cloudevents#222), fixes [cloudevents#221](cloudevents#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([cloudevents#223](cloudevents#223), fixes [cloudevents#175](cloudevents#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
jskeet
added a commit
that referenced
this issue
Sep 8, 2022
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([#236](#236)) - Feature: Allow empty payloads in Kafka ([#224](#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([#234](#234), part of [#231](#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([#226](#226), fixes [#225](#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([#220](#220), fixes [#219](#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([#222](#222), fixes [#221](#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([#223](#223), fixes [#175](#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
ericdotnet
added a commit
to ericdotnet/CSharp-sdk-dev
that referenced
this issue
May 13, 2024
Changes since 2.3.1: - Feature: Implement underscore prefixes for AMQP (see history) ([#236](cloudevents/sdk-csharp#236)) - Feature: Allow empty payloads in Kafka ([#224](cloudevents/sdk-csharp#224)) - Feature: Implement conversions to and from JObject/JsonElement in JsonEventFormatter ([#234](cloudevents/sdk-csharp#234), part of [#231](cloudevents/sdk-csharp#231)) - Bug fix: Observe JSON serializer options in JsonEventFormat ([#226](cloudevents/sdk-csharp#226), fixes [#225](cloudevents/sdk-csharp#225)) - Bug fix: Put AvroEventFormatter in the right namespace ([#220](cloudevents/sdk-csharp#220), fixes [#219](cloudevents/sdk-csharp#219)) - Bug fix: Use content headers when parsing HTTP requests/responses ([#222](cloudevents/sdk-csharp#222), fixes [#221](cloudevents/sdk-csharp#221)) - Bug fix: Perform release builds with ContinuousIntegrationBuild=true ([#223](cloudevents/sdk-csharp#223), fixes [#175](cloudevents/sdk-csharp#175)) Signed-off-by: Jon Skeet <jonskeet@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hey team,
I'm looking for some advise and/or workaround for my issue. My goal is to create a JSON string (pretty and non-pretty).
As of now, I am using the JsonEventFormatter with the indentation options. The SDK is however not respecting this setting.
The below codebase is showing this problem.
Result:
![image](https://user-images.githubusercontent.com/20299573/181782555-2a33cfee-bb6a-4133-b34a-472cc1807372.png)
The text was updated successfully, but these errors were encountered: