Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vi swp file #1020

Merged
merged 1 commit into from Feb 21, 2024
Merged

Remove vi swp file #1020

merged 1 commit into from Feb 21, 2024

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Feb 20, 2024

Fixes #1019

Signed-off-by: Doug Davis <dug@microsoft.com>
@duglin
Copy link
Contributor Author

duglin commented Feb 20, 2024

/cc @matzew
thanks for noticing!

@duglin
Copy link
Contributor Author

duglin commented Feb 20, 2024

@embano1 @lionelvillard for a quick/easy review

Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matzew
Copy link
Member

matzew commented Feb 20, 2024

@duglin are you doing a 2.15.1 patch release for this?

@duglin
Copy link
Contributor Author

duglin commented Feb 20, 2024

If knative needs us to then I think we should

@matzew
Copy link
Member

matzew commented Feb 20, 2024 via email

@duglin duglin merged commit 67e3899 into cloudevents:main Feb 21, 2024
9 checks passed
@duglin duglin deleted the oops branch February 21, 2024 15:25
@duglin
Copy link
Contributor Author

duglin commented Feb 21, 2024

New release: https://github.com/cloudevents/sdk-go/releases/tag/v2.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protocol.go.swp file for http protocol?
3 participants