Fix the content-type issue for the MQTT protocol
#1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanmxa
force-pushed
the
br_mqtt_stru
branch
3 times, most recently
from
fdc7415
to
ab4b6b9
Compare
|
This is a bug of the MQTT protocol in the structured mode. Please take a look @embano1 ~ |
embano1
reviewed
Jun 6, 2024
protocol/mqtt_paho/v2/message.go
Outdated
| @@ -42,7 +41,7 @@ func NewMessage(msg *paho.Publish) *Message { | |||
| var v spec.Version | |||
| if msg.Properties != nil { | |||
| // Use properties.User["Content-type"] to determine if message is structured | |||
There was a problem hiding this comment.
should this comment be removed then?
| } | ||
| if err != nil { | ||
| return | ||
| } | ||
| } | ||
|
|
||
| contentType := m.internal.Properties.ContentType |
There was a problem hiding this comment.
question: no changes needed for structured encoding?
There was a problem hiding this comment.
We still need it here, cause the attribute datacontenttype of the event is decoded from this field with a binary message
yanmxa
force-pushed
the
br_mqtt_stru
branch
2 times, most recently
from
89a0e0f
to
563be8b
Compare
Signed-off-by: myan <myan@redhat.com>
embano1
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: myan myan@redhat.com
Fixed: #1062