Bindings optimization to support binary -> binary + some refactoring #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
force-pushed
the
bindings-optimize
branch
from
cf0321c
to
c5856e5
Compare
|
HTTP binding now working (with tests too), AMQP still WIP |
|
AMQP implemented, still some stuff broken because of encoding |
slinkydeveloper
force-pushed
the
bindings-optimize
branch
2 times, most recently
from
a4fc562
to
8acac5c
Compare
|
OH MY! this is going to be grand, thanks for looking at this. |
Non-functioning code! This is an API proposal for cloudevents#262 NOTE: the proposal is incompatible with current API (adds a method to Message) If it needs to be made compatible, the Binary() method can be moved to a new interface (e.g. BinaryMessage) and the user can cast. Signed-off-by: Alan Conway <aconway@redhat.com>
Added Transcoders, to transcode message between sender and receiver Reimplemented http & amqp binding with new interfaces Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Added translate function, to abstract message reading process Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
bindings-optimize
branch
from
8acac5c
to
ca7820b
Compare
|
Rebased with master, now it's ready to review 😄 |
slinkydeveloper
changed the title
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262
Depends on #274
Overview
Starting from @alanconway work (#263) I've reorganized a bit the
Messageinterface to allow both binary -> binary message passing and structured -> structured.The
Encoderpattern allows to the receiver message to extract informations and to the sender to encode these informations in the right request structure.I modified both HTTP and AMQP binding implementations to support new interfaces.
Benchmark
From https://github.com/cloudevents/sdk-go/tree/master/test/benchmark/http
8Kb payload (left is #274, right is this patch)
16Kb payload (left is #274, right is this patch)
32Kb payload (left is #274, right is this patch)
