Combine request context with parent receiver context #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmoss
force-pushed
the
inheriting-contexts
branch
3 times, most recently
from
a1a6be6
to
17cdb77
Compare
PR cloudevents#718 changed the handler to always receive the request context in order to support middleware that alters the context. This however means we lose any context values (loggers, etc) that are set on the outer context. This change introduces a delegating context that will prioritize the child (request) context for values and cancellation, but fallback to the parent context for missing values. Signed-off-by: Ben Moss <benm@vmware.com>
benmoss
force-pushed
the
inheriting-contexts
branch
from
17cdb77
to
4d48d54
Compare
n3wscott
approved these changes
Oct 22, 2021
n3wscott
pushed a commit
that referenced
this pull request
Oct 22, 2021
PR #718 changed the handler to always receive the request context in order to support middleware that alters the context. This however means we lose any context values (loggers, etc) that are set on the outer context. This change introduces a delegating context that will prioritize the child (request) context for values and cancellation, but fallback to the parent context for missing values. Signed-off-by: Ben Moss <benm@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #718 changed the handler to always receive the request context in
order to support middleware that alters the context. This however means
we lose any context values (loggers, etc) that are set on the outer
context.
This change introduces a delegating context that will prioritize the
child (request) context for values and cancellation, but fallback to the
parent context for missing values.
Fixes #732