Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unordered, unknown datacontenttype test and errors to v2/event #787

Merged
merged 1 commit into from Jul 27, 2022

Conversation

n3wscott
Copy link
Member

fixes: #782

Signed-off-by: Scott Nichols n3wscott@chainguard.dev

Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
@n3wscott
Copy link
Member Author

mind doing a review @agriess ?

Copy link

@agriess agriess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@n3wscott n3wscott merged commit 93d324d into cloudevents:main Jul 27, 2022
@n3wscott n3wscott deleted the 782-json-invalid branch July 27, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json Unmarshaller ignores error around reading 'data' when 'datacontenttype' is invalid
2 participants