Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding header plumbing to the http transport. #82

Merged
merged 3 commits into from
Mar 20, 2019

Conversation

n3wscott
Copy link
Member

Signed-off-by: Scott Nichols nicholss@google.com

Signed-off-by: Scott Nichols <nicholss@google.com>
Copy link
Contributor

@Harwayne Harwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will help me greatly, as it lets me pass tracing headers through when using the SDK's HTTP transport and client.

@@ -10,6 +12,50 @@ type TransportContext struct {
URI string
Host string
Method string
Header http.Header

// This is e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete sentence.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Scott Nichols added 2 commits March 20, 2019 11:23
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Scott Nichols <nicholss@google.com>
@n3wscott n3wscott marked this pull request as ready for review March 20, 2019 18:31
@markpeek markpeek merged commit a4c06e5 into cloudevents:master Mar 20, 2019
nachocano pushed a commit to nachocano/sdk-go that referenced this pull request Mar 21, 2019
Signed-off-by: Scott Nichols <nicholss@google.com>
Signed-off-by: Nacho Cano <nachoacano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants